Conversation
…ion and dragging - Adds custom transient/marker slicing UI to `WaveformDisplay.tsx` - Adds ability to double-click to add/remove slice markers - Adds drag-to-adjust slice boundary handles with explicit hover affordances - Exposes `setAlignment` from `sampleManagement.ts` audio engine hook to properly pipe the modified manual slice parameters to the audio thread - Updated `agent_plan.md` to reflect progress and adds new "Auto-Slice by Transients" goal to Innovation Lab Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This PR implements the "Custom Sample Slicing UI" from the
agent_plan.mdActive Backlog.Features
WaveformDisplaynow allows users to manually define and manipulate sample slice markers when instretchmode for theSampler.col-resizeand clicking and dragging adjusts the boundary between two slices natively.useAudioEnginehook now exports asetAlignmentfunction, passed down toSamplerPaneland mapped toonAlignmentChange, bridging the React state update of these boundaries with the underlyingPhonemeAlignerrepresentations so they function identically to TTS syllables.agent_plan.mdhas been successfully updated, marking this feature complete and moving the logical next step ("Auto-Slice by Transients") to the Innovation Lab.Verification
pnpm test,pnpm lint, andpnpm build.mainto ensure clean resolution.PR created automatically by Jules for task 14867844128597551224 started by @ford442